Adyen / adyen-magento2

Adyen Payment plugin for Magento2
MIT License
155 stars 211 forks source link

[PW-1941] Payment form (hpp) gets cleared when change city #563

Closed vovayatsyuk closed 3 years ago

vovayatsyuk commented 4 years ago

Magento version: 2.3.2 Plugin version: 4.4.0

Description

  1. Navigate to checkout and proceed to the payment step.
  2. Select "Klarna Faktura" payment method and fill "Personal number" field.
  3. Uncheck "use shipping address" checkbox and change City to something else.
  4. Update billing address.
  5. "Personal number" field gets cleared.

This issue happens with all "hpp" methods. ("Bankbetalning" for example.)

p.d. In fact, you can even press "Cancel" button, just wait a second after that:

hpp

You can also run this code snippet in browser console and form will be cleared too:

require(['Magento_Checkout/js/model/quote'], function(quote) {
    quote.shippingAddress(quote.shippingAddress())
});
cyattilakiss commented 4 years ago

Hi @vovayatsyuk ,

Thank you for raising this issue, we are going to pick this up into our backlog. This should only happen if the shipping address is changed and not the billing address.

Best, Attila Adyen

vovayatsyuk commented 4 years ago

@cyattilakiss is it possible to remove this behavior for both addresses? Asking because it will fix conflict with the firecheckout module.

In short, firecheckout calls for standard shipping.validateShippingInformation method when you press 'Place Order'. Unfortunately validateShippingInformation updates shipping address as well :(.

Here is the part of validateShippingInformation method:

https://github.com/magento/magento2/blob/7aa94564d85e408baea01abc5315a0441401c375/app/code/Magento/Checkout/view/frontend/web/js/view/shipping.js#L324-324

selectShippingAddress(shippingAddress);

This results in cleared hpp forms when user pressed "Place Order".

othuress commented 4 years ago

@cyattilakiss @rikterbeek I would love your comment on @vovayatsyuk question. Thank you Ola

cyattilakiss commented 4 years ago

Hi @vovayatsyuk , @othuress ,

We are still assessing what approach would be the best to fix the conflict with the one step checkout modules while keeping our multi payment method functionality. Sorry for the delay on this, we need to change some basic flows and we are still planning it. The item is in our backlog, will be refined and picked up as soon as we can.

Thank you for your patience and happy holidays! Best, Attila Adyen

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

lukaszlempicki-sii commented 4 years ago

@cyattilakiss How is it going with fixing this issue?

AlexandrosMor commented 4 years ago

Hello @vovayatsyuk,

I see there is an internal ticket for this issue. We are going to add it to our future sprints.

kind regards, Alexandros

othuress commented 4 years ago

Hello @AlexandrosMor ,

could it be this one? Request #749667

AlexandrosMor commented 4 years ago

Hello @othuress.

Can you be more specific about the number ? Is it a github PR ?

othuress commented 4 years ago

@AlexandrosMor No it is adyen ticet

floorjubbega commented 3 years ago

Duplicate of #561