search

Adyen / adyen-openapi

OpenAPI specification for the Adyen APIs
MIT License
67 stars 50 forks source link

CheckoutService v51 yaml PaymentResponse have incorrect required property #13

Closed mikaelalbrektsson closed 4 years ago

mikaelalbrektsson commented 4 years ago

Hi,

The yaml file for CheckoutService v51 has specified required on PaymentResponse for property merchantReference. This is incorrect because it's not always part of the response depending of resultCode.

If the resultCode of the response is "IdentifyShopper" or "RedirectShopper", the json returned from the api does not contain the merchantReference attribute.

PaymentResponse:
      properties:
        merchantReference:
          description: |-
            The reference to uniquely identify a payment. This reference is used in all communication with you about the payment status. We recommend using a unique value per payment; however, it is not a requirement.
            If you need to provide multiple references for a transaction, separate them with hyphens ("-").
            Maximum length: 80 characters.
          type: string
      required:
        - merchantReference
a-akimov commented 4 years ago

@mikaelalbrektsson, thank you!

This should be fixed in the update today.