Closed gunnartorfis closed 3 weeks ago
descorp
commented
1 month ago Hey @gunnartorfis
Thanks for feedback 💚 New arch was on our backlog for a long time. Probably already too long 😅
We will start looking into it!
@adyen/react-native crashes with the new architecture enabled
Any particular steps to reproduce? RN version ?
gunnartorfis
commented
1 month ago It crashes as soon as I try to use AdyenCheckout for example but it might be just as soon as there's an import to adyen/react-native.
I'm on 0.74.5 using Expo.
descorp
commented
1 month ago @gunnartorfis
How is your project configured / initiated ?
I have created new expo project (RN 0.74.5) with npx create-expo-app --template blank and enabled new architecture: it works for me on Android 🤔
UPD
iOS crashes for me on getReturnURL:rejecter: from SessionHelper
Do you receive simmilar crash ?
UPD
This crash was caused by missed declaration. Fixed #529
gunnartorfis
commented
1 month ago Hey @descorp
It was initialized 6 years ago 😅 , but is just an Expo app these days.
That iOS crash looks like the one I got! Looking forward to see that merge released so I can test it out.
camil-adyen
commented
3 weeks ago Closing this issue for now. Feel free to reopen if anything else needs to be addressed.
Is your feature request related to a problem? Please describe. Currently @adyen/react-native crashes with the new architecture enabled even though the build succeeds.
Describe the solution you'd like It should be compatible with the new arch.
Additional context Here's a writeup from the React Working Group about what needs to be done to support the new arch: https://github.com/reactwg/react-native-new-architecture/blob/main/docs/enable-libraries.md
I'd be happy to contribute even though I don't have any experience with adopting the new arch.