search

Adyen / adyen-salesforce-commerce-cloud

Salesforce Commerce Cloud (formerly Demandware)
MIT License
90 stars 75 forks source link

Domain Association Apple Pay #1141

Open KennethRobbeFrucon opened 4 weeks ago

KennethRobbeFrucon commented 4 weeks ago

Describe the bug Logic was added inside this PR to always add a line break add the end of the domain association file for Apple Pay (/.well-known/apple-developer-merchantid-domain-association). This was added because the previous domain association file of Adyen included a line break at the end. However, the new file no longer contains this line break, so there's always a mismatch between the value that's presented by SFCC and the original value.

To Reproduce Steps to reproduce the behavior:

  1. Fill in the domain association value (without line break) through the preference-module
  2. A line break is added at the end of the value on the SFCC URL (/.well-known/apple-developer-merchantid-domain-association)
  3. It is not possible to activate the payment method on Adyen Production, as the values of the files don't match.

Expected behavior Value presented by SFCC should no longer contain the line break.

zenit2001 commented 4 weeks ago

Hi @KennethRobbeFrucon ,

Thanks for your report. Can you please provide us some more information:

With kind regards, Zenit Adyen

KennethRobbeFrucon commented 4 weeks ago

Hi @zenit2001,

We're using 23.3.1, but the code that adds the line break is still present in the latest version:

https://github.com/Adyen/adyen-salesforce-commerce-cloud/blob/4da8a1d3392dd33e94a5581fc5db028ec1a249e6/cartridges/int_adyen_SFRA/cartridge/controllers/RedirectURL.js#L14

I've tried updating the value through both the Adyen settings page & the regular BM Site preferences module

Kind regards, Kenneth

zenit2001 commented 4 weeks ago

Hi @KennethRobbeFrucon ,

Thank you for your quick reply. We will setup an investigation and keep you updated for the status. In the meantime, in case you want to remove the line break, you can replace println with print.

With kind regards, Zenit Adyen

KennethRobbeFrucon commented 4 weeks ago

Hi @zenit2001,

That's indeed what we have done at the moment. I can confirm that solves the issue.

Kind regards, Kenneth