Fallback to default config values

acampos1916 commented 3 years ago

Is your feature request related to a problem? Please describe. If a config value (API key, merchant account, etc.) is not present then this value should be used from the main store or default.

If there's no default value for that config field an error should be shown (when relevant).

Additional context As discussed in #109

bortefi commented 3 years ago

Context of #109

Checking if the parameters are empty would be the API key regarding the env.

So if for an additional store the live API key is empty: take all Live settings from the main store.

if an API Key is filled but no merchant account -> it will fail as it would take the configuration of that storefront

please feel free to add conditions, or intended ways of working

Additional:

Verify default fallback of Shopware 5, on dynamic configuration:
- does it take all main store settings as a default?
- does it also use fallback to main store on partial data: in case TEST data is provided, but LIVE values are not, which data is used for LIVE?

cyattilakiss commented 3 years ago

@acampos1916 can this issue be closed?

acampos1916 commented 3 years ago

@cyattilakiss not yet as there's still no fallback to default values https://github.com/Adyen/adyen-shopware5/pull/109#issuecomment-758606966

acampos1916 commented 3 years ago

Fixed in #155

Adyen / adyen-shopware5

Fallback to default config values #112