search

Adyen / adyen-shopware6

Adyen Payment plugin for Shopware 6
MIT License
21 stars 22 forks source link

Server error when opening a order without a transaction with Adyen payment method #479

Closed SpiGAndromeda closed 5 months ago

SpiGAndromeda commented 6 months ago

Describe the bug When opening an order from the Shopware administration that doesn't use an Adyen payment method, an error is thrown by Shopware:

[2024-04-17T11:47:23.390554+00:00] php.CRITICAL: Uncaught Error: Call to a member function getPaymentMethod() on null {"exception":"[object] (Error(code: 0): Call to a member function getPaymentMethod() on null at /shopware/custom/plugins/AdyenPaymentShopware6/src/Controller/AdminController.php:305)"} []
[2024-04-17T11:47:23.390951+00:00] request.CRITICAL: Uncaught PHP Exception Error: "Call to a member function getPaymentMethod() on null" at AdminController.php line 305 {"exception":"[object] (Error(code: 0): Call to a member function getPaymentMethod() on null at /shopware/custom/plugins/AdyenPaymentShopware6/src/Controller/AdminController.php:305)"} []

Because this happens async, the admin interface still works seemingly normal.

Versions Shopware version: 6.5.8.7 Plugin version: 3.14.4

To Reproduce Adyen payment methods have be enabled. The error will be thrown and appear in the logs anytime a order is opened that contains no transaction with Adyen payment.

Additional context I already investiagted the problem and found a solution.

This method fetches the first transaction of the order that uses a Adyen payment method: https://github.com/Adyen/adyen-shopware6/blob/70fefb29fbb26ff79decc4dceee282580d64e344/src/Controller/AdminController.php#L301

It should return false if no matching transaction was found by catching any thrown exception, including calling a method on null. However, calling a method on null doesn't throw an exception but an error.

The method is called in JS by the adyen-payment-capture component: https://github.com/Adyen/adyen-shopware6/blob/70fefb29fbb26ff79decc4dceee282580d64e344/src/Resources/app/administration/src/component/adyen-payment-capture/index.js#L111 JS error handling catches the 500 response from Shopware and doesn't render the component ... which is correct in the end.

Easy fix: use \Throwable instead of \Exception (or \Error if only errors should be catched) in the catch clause. However, I sould suggest handling nulls more explicitly because the method expects that there can be nulls and because throwing exceptions is performancy heavy in PHP (https://php.watch/articles/php-exception-performance).

I will create a PR for that, but I wanted to ask if there are other places in the code where this conpect is used.

RokPopov commented 5 months ago

Closing the issue, as the PR addressing it was already released in v3.15.0