Adyen / adyen-shopware6

Adyen Payment plugin for Shopware 6
MIT License
21 stars 22 forks source link

Version bump of php-api-library in 3.16.X #573

Open phillensen opened 4 days ago

phillensen commented 4 days ago

Describe the bug We are using Shopware 6.5 and thus version 3.16.x of the Shopware 6 Adyen plugin. Currently this plugin is requiring package adyen/php-api-library with version ^17.5.0

"require": {
        "shopware/core": "~6.4.0 || ~6.5.0",
        "shopware/storefront": "~6.4.0 || ~6.5.0",
        "adyen/php-api-library": "^17.5.0",
        "adyen/php-webhook-module": "0.8.0",
        "ext-json": "*"
    },

We stumbled upon a bug that has already been fixed in adyen/php-api-library (Link1, Link2).

Currently it is not possible to buy products that don't have an itemCategory. The result is that we have a lot of orders where the payment fails (i.e. with Klarna Pay Now and Klarna Pay Later, as they are using the AbstractPaymentMethodHandler.

I saw that the version of adyen/php-api-library was increased in the Shopware 6 Adyen plugin, but only for Version 4.1.X and above. And thus only for Shopware 6.6 shops and not for Shopare 6 shops running on SW 6.5. (Link3).

Is it possible to raise the the version of adyen/php-api-library to at least 18.2.1 in versions 3.16.X so Shopware 6.5 shops can benefit from this bugfix too? (Link4)

Versions Shopware version: 6.5.8.13 Plugin version: 3.16.1

To Reproduce Steps to reproduce the behavior:

  1. Add a product to the cart that doesn't have an itemCategory
  2. Go to checkout, select a payment method that is using AbstractPaymentMethodHandler (i.e. Klarna Pay Now or Klarna Pay Later) and finish checkout
  3. The following error is thrown: There was an error with the payment method. Order number: XXXXXXXXX Missing data: non-nullable itemCategory cannot be null [] []
  4. Customer gets redirected to page /account/order/edit/0193448XXXXXXXXXXXXXe8b331e012?error-code=CHECKOUT__UNKNOWN_ERROR, the order is placed, but the payment failed.

Expected behavior Its possible to buy products without an itemCategory in a Shopware 6.5 shop.