search

Adyen / adyen-web

Adyen Web Drop-in and Components
https://docs.adyen.com/online-payments
MIT License
183 stars 130 forks source link

Pass `buttonRadius` prop into Google Pay Button #2669

Closed fr-richard closed 2 months ago

fr-richard commented 5 months ago

Problem: We cannot customize Google Pay button radius.

Is your feature request related to a problem? Please describe. In the GooglePayButton component, it should support buttonRadius prop, however, Adyen's Google Pay button doesn't pass buttonRadius prop

GooglePayButton documentation: https://developers.google.com/pay/api/web/reference/request-objects#ButtonOptions

Adyen Google Pay button documentation: https://docs.adyen.com/payment-methods/google-pay/web-component/

Proposed solution: Adyen should pass borderRadius prop here https://github.com/Adyen/adyen-web/blob/main/packages/lib/src/components/GooglePay/GooglePay.tsx#L135-L143

ribeiroguilherme commented 3 months ago

Hey @fr-richard ,

Thanks for flagging this. It is a new property that got added recently in the GooglePay SDK: https://developers.google.com/pay/api/web/support/release-notes#mar-24

We will add support for it and I will let you know once we release that.

ribeiroguilherme commented 2 months ago

Hey @fr-richard - we added this feature in the most recent release. Thanks for flagging it. Cheers!