search

Adyen / adyen-web

Adyen Web Drop-in and Components
https://docs.adyen.com/online-payments
MIT License
184 stars 130 forks source link

CustomTranslations type is not exported in 6.3.0 #2893

Closed jsyrjala closed 2 weeks ago

jsyrjala commented 3 weeks ago

Describe the bug

Seems to me that type CustomTranslations is not exported correctly, so importing it doesn't work in 6.3.0. This used to work in 5.70.0.

Possibly this affects also earlier 6.x.x versions, I didn't test those.

For example interface CoreConfigration is exported and that interface refers to type CustomTranslations. So I'd expect that CustomTranslations is also exported. See https://github.com/Adyen/adyen-web/blob/683a5708ab8093735c9d09da4668536e2f5af27b/packages/lib/src/core/types.ts#L96-L133

To Reproduce Steps to reproduce the behavior:

  1. Import adyen web to you node project
  2. Try to import type CustomTranslations

Expected behavior

I'd expect that I can import type CustomTranslations.

Desktop (please complete the following information):

Additional context

When looking at node_modules/@adyen/adyen-web/dist/cjs/index.d.cts there are following

type CustomTranslations = {
    [locale: string]: Translations;
};

and at the end of file there is this export statement. This doesn't contain CustomTranslations.

export { ANCVElement as ANCV, type ANCVConfiguration, type ANCVDataState, AchElement as Ach, type AchConfiguration, type ActionDescriptionType, type ActionHandledReturnObject, type AdditionalDetailsActions, type AdditionalDetailsData, AddressElement as Address, type AddressData, type AddressField, AdyenCheckout, AdyenCheckoutError, Affirm, AfterPay, AfterPayB2B, AmazonPayElement as AmazonPay, type AmazonPayBackendConfiguration, type AmazonPayButtonProps, type AmazonPayButtonSettings, type AmazonPayComponentProps, type AmazonPayConfiguration, type AmazonPayElementData, type AnalyticsModule, type App, ApplePayElement as ApplePay, type ApplePayButtonType, type ApplePayConfiguration, type ApplePayElementData, type ApplePayPaymentAuthorizationResult, type ApplePayPaymentOrderDetails, type ApplePaySessionRequest, Atome, type AwaitComponentProps, type AwaitConfiguration, BacsElement as BacsDirectDebit, BancontactElement as Bancontact, type BankDetailsSchema, BankTransferElement as BankTransfer, type BankTransferConfiguration, type BankTransferSchema, type BankTransferState, BCMCMobileElement as BcmcMobile, type BeforeSubmitActions, BillDeskOnlineElement as BillDeskOnline, BillDeskWalletElement as BillDeskWallet, type BinLookupResponse, type BinLookupResponseRaw, BlikElement as Blik, BoletoElement as Boleto, type BoletoElementProps, type BoletoInputDataState, type BoletoInputErrorState, type BoletoInputValidState, type BrandConfiguration, type BrandObject, type BrowserInfo, type CReqData, CardElement as Card, type CardBackendConfiguration, type CardBrandsConfiguration, type CardConfiguration, type CardElementData, CashAppPay, type CashAppPayConfiguration, type CashAppPayElementData, type CashAppPayEventData, type ChallengeData, type ChallengeResolveData, type ChangeActionOptions, type ChangePaymentDetailsButtonProps, type ChargeAmount, type CheckoutAdvancedFlowResponse, type CheckoutDetailsRequest, type CheckoutSessionConfig, ClickToPayElement as ClickToPay, type ClickToPayConfiguration, type ClickToPayPaymentData, type ClickToPayProps, type ClickToPayScheme, type ComponentFocusObject, type ComponentMethodsRef, type CoreConfiguration, type Currency, CustomCard, type CustomCardConfiguration, type DecodeObject, type DeliverySpecifications, DokuElement as Doku, type DokuVoucherResultProps, DonationElement as Donation, type DonationConfiguration, DotpayElement as Dotpay, DragonpayElement as Dragonpay, type DragonpayConfiguraton, type DragonpayInputData, type DragonpayInputIssuerItem, type DragonpayInputProps, type DragonpayVoucherResultProps, DropinElement as Dropin, type DropinComponentProps, type DropinComponentState, type DropinConfiguration, type DropinStatusProps, type DualBrandSelectElement, DuitNowElement as DuitNow, EPSElement as EPS, EcontextElement as Econtext, type EcontextConfiguration, type EcontextInputSchema, type EcontextVoucherResultProps, type ErrorCodeObject, type ExtendedMerchantInfo, FacilyPay10x as FacilPay10x, FacilyPay12x as FacilPay12x, FacilyPay3x as FacilPay3x, FacilyPay4x as FacilPay4x, FacilyPay6x as FacilPay6x, type FieldsetVisibility, type FingerPrintData, type FingerprintResolveData, type FundingSource, type GiftCardConfiguration, type GiftCardElementData, GiftcardElement as Giftcard, GiropayElement as Giropay, GooglePay, type GooglePayConfiguration, type GooglePaymentDataRequest, type ICore, type IDropin, type InstantPaymentTypes, type Intent, type IssuerListConfiguration, type IssuerListData, type KlarnConfiguration, KlarnaPayments as Klarna, type KlarnaSdkData, type KlarnaWidgetAuthorizeResponse, type KlarnaWidgetProps, type LedgerCurrencies, MBWayElement as MBWay, MealVoucherFRElement as MealVoucherFR, MolPayEBankingMYElement as MolPayEBankingMY, MolPayEBankingTHElement as MolPayEBankingTH, MolPayEbankingVNElement as MolPayEBankingVN, MultibancoElement as Multibanco, type MultibancoVoucherResultProps, type OnChangeData, OnlineBankingCZElement as OnlineBankingCZ, OnlineBankingFI, OnlineBankingINElement as OnlineBankingIN, OnlineBankingPL, OnlineBankingSKElement as OnlineBankingSK, type OpenInvoiceActiveFieldsets, type OpenInvoiceConfiguration, type OpenInvoiceFieldsetsRefs, type OpenInvoiceProps, type OpenInvoiceStateData, type OpenInvoiceStateError, type OpenInvoiceStateValid, type OpenInvoiceVisibility, type Order, type OrderButtonProps, type OrderStatus, OxxoElement as Oxxo, type OxxoVoucherResultProps, type PayButtonFunctionProps, PayByBank, PayByBankUS, PayMeElement as PayMe, PayNowElement as PayNow, PaypalElement as PayPal, type PayPalConfiguration, type PayloadJSON, type PaymentAction, type PaymentActionsType, type PaymentAmount, type PaymentAmountExtended, type PaymentCompletedData, type PaymentData, type PaymentFailedData, type PaymentMethod, type PaymentMethodData, type PaymentMethodGroup, type PaymentMethodOptions, type PaymentMethods$1 as PaymentMethods, type PaymentMethodsConfiguration, type PaymentMethodsRequestData, type PaymentMethodsResponse, type PaymentResponseData, PayuNetCashcardElement as PayuCashcard, PayuNetBankingElement as PayuNetBanking, PersonalDetailsElement as PersonalDetails, type PersonalDetailsSchema, PixElement as Pix, type PixConfiguration, type PixElementData, type PostMsgParseErrorObject, type ProcessedResponse, PromptPayElement as PromptPay, type QRLoaderConfiguration, RatePay, RatePayDirectDebit, type RawPaymentResponse, type RecurringMetadata, RedirectElement as Redirect, type RedirectConfiguration, type Region, type ResultCode, type ResultObject, type ResultValue, Riverty, type SepaConfiguration, SepaElement as SepaDirectDebit, type SepaElementData, type SessionsResponse, type SignOutButtonProps, type SocialSecurityMode, type StatusObject, type StoredPaymentMethod, type SubmitActions, type SubmitData, type SupportedLocale, SwishElement as Swish, ThreeDS2Challenge, type ThreeDS2ChallengeConfiguration, ThreeDS2DeviceFingerprint, type ThreeDS2DeviceFingerprintConfiguration, type ThreeDS2FingerprintResponse, type ThreeDS2FlowObject, type ThreeDS2Token, TrustlyElement as Trustly, TwintElement as Twint, UIElement, type UIElementProps, type UIElementStatus, UPI, type UPIConfiguration, type UpdateAmazonCheckoutSessionRequest, type UpiMode, type UpiPaymentData, type UpiType, type ValidationError, VippsElement as Vipps, type VoucherConfiguration, type VoucherDetail, type VoucherProps, WalletINElement as WalletIN, WeChatPayElement as WeChat, type balanceCheckResponseType, index_d as components, type onBalanceCheckCallbackType, type onOrderCancelData, type onOrderCancelType, type onOrderRequestCallbackType, type onRequiringConfirmationCallbackType };
sponglord commented 2 weeks ago

@jsyrjala - this will be fixed in our next release. Thanks for pointing it out.