🐛 Added support for grouped charts with varied data points. - Githubissues

Adyen / lume

Lume is a component library for visual representations of data, built for Vue with D3.

https://lumedataviz.com

MIT License

37 stars 1 forks source link

🐛 Added support for grouped charts with varied data points. #325

Closed govind-srinidhi closed 8 months ago

govind-srinidhi commented 8 months ago

Relates to #324

📝 Description

Currently tooltips in grouped chart breaks whenever the number of data points between items in the group are different.

This PR covers:

Checking if the data points for atleast one of the item is present before showing the tooltip. If so, the tooltip has to show up.
Updated tests and stories to cover this scenario.

Add a brief description

💥 Is this a breaking change (Yes/No):

[x] No
[ ] Yes (please describe the impact and migration path for existing Lume users)

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

netlify[bot] commented 8 months ago

Deploy Preview for adyen-lume ready!

Name	Link
Latest commit	183e12310bceb9de2337e3d0c658a637b3bbe685
Latest deploy log	https://app.netlify.com/sites/adyen-lume/deploys/6548fa983425cb0008157a7f
Deploy Preview	https://deploy-preview-325--adyen-lume.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.