Adyen / lume

Lume is a component library for visual representations of data, built for Vue with D3.
https://lumedataviz.com
MIT License
37 stars 1 forks source link

🐛 Fix lume-tooltip use v-if instead of v-show #416

Closed joao-m-santos closed 3 months ago

joao-m-santos commented 3 months ago

📝 Description

Using v-show on tooltip would force consumers (especially custom tooltip implementations) to handle hoveredIndex = -1 cases (when tooltip is not shown).
This way there's no need to handle those cases because the tooltip will only render if hoveredIndex > -1

💥 Is this a breaking change (Yes/No):

📝 Additional Information

--

Before submitting the PR, please make sure you do the following

netlify[bot] commented 3 months ago

Deploy Preview for adyen-lume ready!

Name Link
Latest commit 4cfc3070ea6b70bda921f50f5e5021e8688f0607
Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/65f2f888e70bd000085e14bb
Deploy Preview https://deploy-preview-416--adyen-lume.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.