Adyen / lume

Lume is a component library for visual representations of data, built for Vue with D3.
https://lumedataviz.com
MIT License
37 stars 1 forks source link

🏷️ Improve DX of exported types and export the missing ones. #421

Closed govind-srinidhi closed 2 months ago

govind-srinidhi commented 2 months ago

Relates to #401

πŸ“ Description

Currently the consumer can access Lume types only by navigating the /dist folder something like @adyen/lume/dist/@types/...

It would create a better developer experience if the user can access the types directly from @adyen/lume instead of navigating the entire path.

And certain types for instance AlluvialDiagramOptions are not exported in Vue 2 version of Lume library. Need to go through the list of missing types and export them too.

πŸ’₯ Is this a breaking change (Yes/No):

Before submitting the PR, please make sure you do the following

netlify[bot] commented 2 months ago

Deploy Preview for adyen-lume ready!

Name Link
Latest commit e6dc06e2150d0dfbbff3f28a98f0a98fbc71ad6c
Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/660d246c1235490008db21ed
Deploy Preview https://deploy-preview-421--adyen-lume.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.