🐛 Fix axis alignment when scale domain is 0 to 0 - Githubissues

Adyen / lume

Lume is a component library for visual representations of data, built for Vue with D3.

https://lumedataviz.com

MIT License

44 stars 2 forks source link

🐛 Fix axis alignment when scale domain is 0 to 0 #481

Closed joao-m-santos closed 1 week ago

joao-m-santos commented 1 week ago

📝 Description

Fixes axes alignment when scale domain is zeros. This happens, for instance, when all dataset values are 0.

💥 Is this a breaking change (Yes/No):

[x] No
[ ] Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

--

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

netlify[bot] commented 1 week ago

Deploy Preview for adyen-lume ready!

Name	Link
Latest commit	a343e616e956fad5e1a4fbf0bff419407a5e5c22
Latest deploy log	https://app.netlify.com/sites/adyen-lume/deploys/6732151dd0f9020008030728
Deploy Preview	https://deploy-preview-481--adyen-lume.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud