Aedial / novelai-api

Python API for the NovelAI REST API
https://aedial.github.io/novelai-api/
MIT License
129 stars 17 forks source link

Update allowed python versions #21

Closed Cikmo closed 1 year ago

Cikmo commented 1 year ago

This pull request expands the support to all versions below 4.0, including the existing support for 3.10. It allows for a wider dependency range of >=3.7.2,<4.0, effectively resolving the problem faced with strict dependency managers such as poetry. Previously, if the allowed Python version range exceeded the one specified in the library, it would not be permitted. However, with this change, poetry will be able to add the dependency even if you're using 3.12 or a higher version (which should be a non-issue).

Aedial commented 1 year ago

I knowingly avoided <4.0, as to ensure the specific version was fully functional before allowing it, like a lot of other packages using pyproject do. I guess I could use the dependencies as a lock, but python version for the CI won't be automatically bumped, resulting in untested changes being pushed to Pypi.

Cikmo commented 1 year ago

I knowingly avoided <4.0, as to ensure the specific version was fully functional before allowing it, like a lot of other packages using pyproject do.

I guess I could use the dependencies as a lock, but python version for the CI won't be automatically bumped, resulting in untested changes being pushed to Pypi.

Thing is, I don't think I've seen any library that doesn't allow me to install because I'm using a greater version. All 3.x versions should be non-breaking for nearly all situations, unless you're doing something weird and very specific, which I doubt.