Aedif / TokenVariants

GNU General Public License v3.0
17 stars 12 forks source link

Token Mold Name Override Prevents Token Variant Art Randomiser / Popups from working #139

Closed schmickers closed 9 months ago

schmickers commented 9 months ago

When the modules Token Mold and Token Variant art are active, the token image randomizer and image select pop ups from Token Variant Art do not occur.

Disabling the Name setting in the Token Mold header restores this functionality.

To Reproduce Steps to reproduce the behavior:

  1. Install Token Mold
  2. Install token Variant Art
  3. Create a token
  4. Token image is not randomised by TVA

Expected behavior Token Mold should make its changes to the token name and allow TVA to randomise the image / display an art select pop-up.

Desktop (please complete the following information):

schmickers commented 9 months ago

I have discovered that also using the core options in V11 for prepending or appending names to new tokens also causes the randomiser not to work.

Aedif commented 9 months ago

Since when does core append anything to the token names? 🤔 What's the setting that does this?

Aedif commented 9 months ago

Found the setting and randomization seems to work just fine, same goes for the pop-ups.

I think you might be confused perhaps by needing to adjust the Percentage Match to be lower

image

And the fact that randomization overrides Pop-ups. If you disable randomizaiton you should see pop-ups again.

Aedif commented 9 months ago

With a token selected press Shift + 2, you'll see that no images are found with 70% match. Lower it and the images will show up again. The module has no way of knowing that a pre/postfix has been added to the token name. So it searches on the entire name

Aedif commented 9 months ago

That said... maybe I could check whether the prototype has been set with those settings and then use the prototype name instead of the actual tokens... though I could picture where this might cause a problem in some very rare cases where you have that setting enabled but then manually change the token's name on the canvas and expect the module to use that instead.

schmickers commented 9 months ago

Oh I see. If I enable keyword matches it works as intended. Thank you for the help.