search

Aedif / TokenVariants

GNU General Public License v3.0
17 stars 12 forks source link

Clicking the "Overlay" gear errors out #140

Closed Drowbe closed 9 months ago

Drowbe commented 9 months ago

In the Effects Settings, clicking the overlay gear to configure the overlay throws an error (see screenshot). The overlay window does not open. Error:

effectMappingForm.js:324 Uncaught (in promise) TypeError: $parcel$interopDefault(...) is not a constructor at y._onOverlayConfigClick (effectMappingForm.js:324:5) at HTMLElement.dispatch (jquery.min.js:2:43184) at y.handle (jquery.min.js:2:41168)

Running Foundry V11.308 and module version 4.56.3. Let me know if you need any other info.

-- Thomas

Screenshot 2023-09-21 at 2 46 13 PM

Aedif commented 9 months ago

Update to 4.56.4. Should be resolved

Drowbe commented 9 months ago

Tried to update... says i have latest. I grabbed the 4.56.4 module.json from your repo and installed that way... but it still says version "4.56.3" -- checked the json file at the version number there and it says 4.56.3 instead of 4.56.4. Guessing you forgot to update the version number? Screenshot below was from the file in "TokenVariants/releases/tag/4.56.4"

image

Drowbe commented 9 months ago

Looks like the path to the zip points to 4.56.3 too.

Aedif commented 9 months ago

Ah, I recently changed the structure of the repo and the version didn't get updated in all the right places. There are 2 module.json files at the moment. (https://github.com/Aedif/TokenVariants/blob/master/module.json is the legacy one and that's the one that was updated instead of the newer one)

Anyway, both of them should be updated now.

Drowbe commented 9 months ago

The fix seems to work! Thank you! Now I need to figure out how to overlay an image over an "unconscious" player without changing their token. (I am coding something for saving throws). As always, thanks for the incredible work!