Aedif / TokenVariants

GNU General Public License v3.0
17 stars 12 forks source link

[BUG]: effectIconWrapper.js script somehow is causing the combat tracker to fail to load #141

Open skellitor301 opened 9 months ago

skellitor301 commented 9 months ago

I've been trying to pursue and figure out what is causing this issue, utilizing Find The Culprit, going to Monk thinking something happened with their combat modules, looking through the console, etc. I've shared the relevant info on Monk's github issue tracker which is here: https://github.com/ironmonk88/monks-combat-details/issues/56 I'm bringing the issue here too since it looks like the console has listed effectIconWrapper.js as part of the error that causes the combat tracker to fail to load as shown in the image below. Screenshot 2023-09-23 103852

Aedif commented 9 months ago

Could you confirm if you tried to disable TVA and see if the problem disappeared?

skellitor301 commented 9 months ago

Sorry for the wait. Yes, I can confirm that disabling TVA fixes the issue. I'm able to add and see player tokens in the combat tracker with the module disabled. Any additional information you need I'll happily provide cause I'd like to not play without TVA. It's such a nice QoL module to have automated variation to monster token art.

Aedif commented 9 months ago

Well.. I can't reproduce the problem. There might be another module causing some sort of conflict.

If you can identify which module TVA is clashing with or some way to reproduce it when it's only TVA active then I can try and solve it.

Anyways disabling both of these options should circumvent TVA needing to mess with the tracker:

image

When these are enabled TVA will not only prevent effects from being rendered on the token, but also the tracker.

When disabled, TVA should not touch it at all.

Aedif commented 9 months ago

I tried breaking the tracker with Combat Details and Token Bar active.

skellitor301 commented 9 months ago

I'll see about getting a tidyui json to you of the module list and see if that does anything for you. I'll have to get it later when home.

On Tue, Sep 26, 2023, 09:28 M. Vaitkus @.***> wrote:

I tried breaking the tracker with Combat Details and Token Bar active.

— Reply to this email directly, view it on GitHub https://github.com/Aedif/TokenVariants/issues/141#issuecomment-1735544217, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3WM7X2VCGJZ2ROFIJT6O3X4LJ6JANCNFSM6AAAAAA5EHY2WY . You are receiving this because you authored the thread.Message ID: @.***>

skellitor301 commented 9 months ago

moduleList.json Here's the .json I mentioned. It uses TidyUI system to import. idk if it will auto-subscribe to the modules for you or not.