Aedif / TokenVariants

GNU General Public License v3.0
18 stars 12 forks source link

Add a json source for load names and images #96

Closed p4535992 closed 1 year ago

p4535992 commented 1 year ago

So i add a json options source with this structure:

...
 {
    "name": "Alchemist's Fire",
    "path": "icons/consumables/potions/bottle-round-corked-yellow.webp",
    "tags": ["consumable", "alchemist", "fire"]
  },
  {
    "name": "Alchemist's supplies",
    "path": "icons/containers/bags/pouch-leather-green.webp",
    "tags": ["tool", "alchemist"]
  },
  {
    "name": "Alchemy Jug",
    "path": "icons/containers/kitchenware/jug-terracotta-orange.webp",
    "tags": ["consumable", "jug", "alchemy"]
  },
...

I'm not sure how to integrate searching on tags as well as names though so I'll leave that for a second moment... but otherwise it seems to work.

Aedif commented 1 year ago

Well, first of all commendations for subjecting yourself to this mess of a module. Just to confirm however, do you want to release this for v9 or v10 version of the module? At the moment the master branch is still being used for v9 releases.

All the latest v10 releases have been done off of v10 branch.

p4535992 commented 1 year ago

a ok sorry i will redirect the PR from master to v10 XD this evening