Aedif / tactical-grid

GNU General Public License v3.0
5 stars 4 forks source link

Consider dropping ATC cover code #32

Closed caewok closed 2 months ago

caewok commented 2 months ago

Hi! I am the dev for Alt. Token Cover module.

Alt Token Cover v0.7.0 made some changes and now can display cover icons on a per-user basis. As such, I don't think Tactical Grid's display of cover icons is necessary if ATC is installed. So I recommend just removing tokencover (and tokenvisibility, which stopped handling cover awhile ago) from the options in computeCoverBonus. Otherwise, I think the two modules will just end up displaying the same cover icons repeatedly.

If you did want to keep it or access cover calculations for other reasons, you can do that a few different ways:

Aedif commented 2 months ago

https://github.com/Aedif/tactical-grid/releases/tag/1.25.0