Aedif / tactical-grid

GNU General Public License v3.0
5 stars 4 forks source link

Fix settings errors #9

Closed voodoofrog closed 1 year ago

voodoofrog commented 1 year ago

I noticed there's some missing localization and a console warning about a missing colour when you open the settings. These changes fix those issues.

Aedif commented 1 year ago

Thanks for pointing out the localization issue. I've always got Token Variant Art active and so didn't realise Tactical Grid was relying on it's language file.

The rulerColor however cannot be assigned a color. While rulerColor is null or an empty string, it will instead inherit the grid's color which may or may not be black.

The actual solution for the warning is using the foundry's inbuilt handlebars helper within settings.html: {{ colorPicker name="rulerColor" value=rulerColor }}

voodoofrog commented 1 year ago

The actual solution for the warning is using the foundry's inbuilt handlebars helper within settings.html: {{ colorPicker name="rulerColor" value=rulerColor }}

Sorted that out.