Aelpecyem / Besmirchment

The first Fabric-Bewitchment addon!
Creative Commons Zero v1.0 Universal
3 stars 3 forks source link

Lich Ghost Form #10

Open VertigOwl opened 3 years ago

VertigOwl commented 3 years ago

Lich Ghost form crashes other players in the server. I am unable to figure out the cause of this so far.

PresquePlayed commented 3 years ago

Lich Form also causes a crash when entering 3rd person in single player

Aelpecyem commented 3 years ago

can you check the log and find out if another mod is causing this

VertigOwl commented 3 years ago

so im checking the log @Aelpecyem of one of the players that crashed. as far as i can tell, it crashed solely because i went ghost form. crash-2021-05-23_21.38.23-client.txt

Aelpecyem commented 3 years ago

Can you reproduce this with only Besmirchment and dependencies?

drewtheuselessmage commented 3 years ago

I mentioned this issue on the discord myself, the crash appears to be caused by origins. Also the crash seems to only happen when attempting to render the ghost form, so long as nobody can see it, they don't crash.

Aelpecyem commented 3 years ago

looking at https://github.com/apace100/origins-fabric/blob/master/src/main/java/io/github/apace100/origins/mixin/LivingEntityRendererMixin.java, it seems that Origins uses a method redirect. I'll probably PR to it or make an issue report to use ModifyArgs instead