Aelto / tw3-random-encounters-reworked

Add randomly generated monster contracts, bounties, ambushes and hunts to the game. Dynamically change the vanilla spawns for unique and varied playthroughs. Simulate an ecosystem and a food chain. Add dynamic events to give more weight to your actions
https://aelto.github.io/tw3-random-encounters-reworked
62 stars 13 forks source link

Compile error fixes for tracker.wss #188

Closed Pav-Osmolski closed 1 year ago

Pav-Osmolski commented 1 year ago

@Aelto Oh you beat me to it!

That was me (gofftiddums) in the Nexus forum suggesting those fixes btw.

Thanks for the update 👍

Aelto commented 1 year ago

Ah! well thanks for the PR ahah. I must say i'm impressed you managed to get it to compile and bundle a release when there is little to no documentation on the subject.

And yes Faen and I worked on the sharedutils recently and his last POTP update includes our recent changes to the modules. I initially wanted to finish what i was working on before pushing a release to avoid having 2 releases back to back but i've been so busy i couldn't even work on what i wanted to add... So i guess i'll push the update right now!

Pav-Osmolski commented 1 year ago

Ah! well thanks for the PR ahah. I must say i'm impressed you managed to get it to compile and bundle a release when there is little to no documentation on the subject.

And yes Faen and I worked on the sharedutils recently and his last POTP update includes our recent changes to the modules. I initially wanted to finish what i was working on before pushing a release to avoid having 2 releases back to back but i've been so busy i couldn't even work on what i wanted to add... So i guess i'll push the update right now!

No problem! Getting it to compile wasn't too tricky, but I did have to make a few cmd fixes which I also included in this PR. I added /D flag to the change directory command which resolve my issues with the script not being able to hop around. Also wrapped %modkitpath% in quotations because I have the mod tools installed in Program Files.

Aelto commented 1 year ago

Excellent, thanks for the tweaks to the scripts. I'm always for more robust scripts, batch isn't my strong suit so i'll trust you on the /D flag on the CD!

I'm merging the PR.

EDIT: i will delete your comment on nexusmods to avoid duplicates, but i appreciate your notice about the compilation issues and the work you submitted!