Improper use of static causes class instances to only have one set of data

Aenigma / ActionMockup

Other

1 stars 0 forks source link

Improper use of static causes class instances to only have one set of data #3

Closed Aenigma closed 10 years ago

Aenigma commented 10 years ago

In several files, members which should be instance variables are made to be class variables.

Here are a few of them:

Driver
RecurringTransaction (additionally, here, you could have totally imported the class instead of writing out the full name)

In general, static should not be used unless the value is a constant. Adding static members with state can cause concurrency issues that will be difficult to fix down the line.

Aenigma commented 10 years ago

This bug is now fixed. Jon fixed Driver in 9eb1943e208ddc82f8a9ed9ce2fd42b9e7bb6ae2 and I fixed RecurringTransaction in e71f3ad50118121e2d432acc3bbeaf8ee98f0c54.