search

Aenigma / ActionMockup

Other
1 stars 0 forks source link

TableMaker #6

Closed Aenigma closed 10 years ago

Aenigma commented 10 years ago

TableMaker is tightly coupled and does too much more than making tables.

Its functionality should be moved to other classes. It implements many of the functionality that are specified to be part of other classes.

Additionally, TableMaker is strictly a utility class. At this point, it does not seem to do much good exposed to the public. Peraps it should be package private or, alternatively, exposed in a separate package such as com.allcoware.actiontaximockup.helpers.

Aenigma commented 10 years ago

It would be really cool if this class was implemented kind of like a factory for JTables that gets rid of all the cruft of using one.

In fact, that's what I thought the name implied, but instead, it was a bunch of methods put together to compose several unrelated components

What would be nice was if you could just pass in a Collection of stuff and it would populate the table with it. Because everywhere we need a table, that is essentially what we want. I'm not sure. Perhaps this functionality can be done with bean binding.

Aenigma commented 10 years ago

I think discussion as far as this issue is considered is moved to #13. This class probably should be deleted later. So, for now, I'm going to close this, too.