Use passed method to calculate diff

Aeolun / react-diff-viewer-continued

A simple and beautiful text diff viewer component made with Diff and React.

https://aeolun.github.io/react-diff-viewer-continued/

MIT License

113 stars 34 forks source link

Use passed method to calculate diff #11

Closed SiebeVE closed 1 year ago

oliver-byteboard commented 1 year ago

@Aeolun A merge on this too would be great!

Aeolun commented 1 year ago

Could you explain what your use case is here (possibly with an example)? I've yet to find a situation in which anything but char diff makes sense for the line level diff.

oliver-byteboard commented 1 year ago

Hi @Aeolun! I believe that without this change, the prop "compareMethod" is not being used at all. I would like to use the diff viewer with "diffWords" so that I can ignore whitespace. Without this PR, we can't change the compareMethod and have it to anything.

Aeolun commented 1 year ago

:tada: This PR is included in version 3.2.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: