search

Aeolun / react-diff-viewer-continued

A simple and beautiful text diff viewer component made with Diff and React.
https://aeolun.github.io/react-diff-viewer-continued/
MIT License
113 stars 34 forks source link

Add handling of big texts #38

Closed giovanni-bellini-argo closed 4 months ago

giovanni-bellini-argo commented 8 months ago

rn the component is really slow or even crashes when handling large texts.

i use it to compare network devices configurations and one of them is over 11.000 lines but i can't seem bo be able to render it nicely.

would be a nice enhancement adding the handling of such texts

TatyanaVl commented 7 months ago

We have the same request

Aeolun commented 6 months ago

Do you have examples of the text you would like to compare?

Aeolun commented 4 months ago

I've tested this with text up to 10MB recently, and I didn't have any significant issues rendering that. Until I get more information on what exactly constitutes too 'big' I'm going to say that's an acceptable size.

If you want me to look at this again, please provide an example of what causes you issues.

Aeolun commented 4 months ago

I'm also happy to accept a PR with the changes that make it faster for your use case (as long as it doesn't break anything for others)