AeonLucid / POGOProtos

A central repository for all proto files of PokémonGO.
MIT License
726 stars 279 forks source link

Hashes are unsigned. xxhash64 returns uint64. #200

Closed iphydf closed 8 years ago

iphydf commented 8 years ago

int64 and uint64 are encoded the same way, with varint encoding: "If you use int32 or int64 as the type for a negative number, the resulting varint is always ten bytes long – it is, effectively, treated like a very large unsigned integer." (See https://developers.google.com/protocol-buffers/docs/encoding#signed-integers). In Java, this change has no effect. In languages that do support unsigned integers, this simplifies client code. Semantically, uint64 is more correct. On the wire, this change has no effect.