search

AeonLucid / POGOProtos

A central repository for all proto files of PokémonGO.
MIT License
726 stars 279 forks source link

StatusCode + PlatformRequest #215

Closed Grover-c13 closed 8 years ago

Grover-c13 commented 8 years ago

StatusCode + PlatformRequest

Grover-c13 commented 8 years ago

Requests:

Responses:

Grover-c13 commented 8 years ago

Still yet to test these changes as an implementation, some of the semantics have changed (unknown6 having a byte type instead of u2).

Please dont merge til i check

Grover-c13 commented 8 years ago

This is good to go, tested with JavaAPI and can get pokestops etc

Grover-c13 commented 8 years ago

Any thoughts anyone?

iGio90 commented 8 years ago

+1

rastapasta commented 8 years ago

+💯 just for the archive, discussion also here

amazing that u/community figured that out!

rastapasta commented 8 years ago

@AeonLucid good to go?

AeonLucid commented 8 years ago

@rastapasta Yeahhh, looks good to me.

iGio90 commented 8 years ago

Merge Simpson!

rastapasta commented 8 years ago

Wuhu! 🎉

marceloueda commented 8 years ago

Great work! I guess there's a typo in the package for GetStoreItemsResponse (https://github.com/AeonLucid/POGOProtos/blob/master/src/POGOProtos/Networking/Platform/Responses/GetStoreItemsResponse.proto#L2)

Grover-c13 commented 8 years ago

Yes sorry! you are right

marceloueda commented 8 years ago

By the way, is there no GetStoreItemsRequest?

Grover-c13 commented 8 years ago

The request takes no arguments, so just send the type with null bytes