search

AeonLucid / POGOProtos

A central repository for all proto files of PokémonGO.
MIT License
726 stars 279 forks source link

VerifyChallengeResponse success optional #240

Closed DrDelay closed 7 years ago

DrDelay commented 7 years ago

I did some testing about completing the captcha and sending the response back, and found that no matter whether I send back a valid or invalid token, I always get HTTP 200 and the status in the ResponseEnvelope is OK.

The only thing is, if it's valid, the response is:

1: 2
2: 205166627
3: "pgorelease.nianticlabs.com/plfe/87"
100 {
  1: 1
}

If it's invalid I get:

1: 2
2: 259741212
3: "pgorelease.nianticlabs.com/plfe/72"
100: ""

So I think the success bool in VerifyChallengeResponse should be optional.

I'm not quite the expert with protobuf, so I'm asking this in an issue instead of opening a PR. Is it even possible to have optional booleans?