search

AeonLucid / POGOProtos

A central repository for all proto files of PokémonGO.
MIT License
726 stars 280 forks source link

Added missing fields found by my auto-generation tools #305

Closed goedzo closed 6 years ago

goedzo commented 6 years ago

By using my auto generation tool of protofiles, I found some missing fields. Here is the fix for the PR.

niicojs commented 6 years ago

Thanks. I think only BattleAttributes is correct,. BattleResults.proto need update and CheckUsername is not there anymore I think.

niicojs commented 6 years ago

also, please don't commit in a PR all those files that includes absolute address that only works on your cmoputer

goedzo commented 6 years ago

@nicoschmitt yes you are right. There are new messages and fields found that have no message files or .proto references. They need to be fixed by adding them the proper way. My tool only finds them and adds them, but doesn't know how to automatically generate them from the source proto file. Nevertheless, this PR can be used to see what needs to be done to fix things.

The extra files I created to be able to build a docker container that can generate the proto files for Pyhton. Only checked them into my own REPO, so not sure how GH decided to put them here. So there is no need to add them too, but feel free to do it anyway, since it is always cool to have a container that can generate the files :).