AequilibraE / aequilibrae

aequilibrae - Python package for transportation modeling
https://www.aequilibrae.com
Other
166 stars 38 forks source link

Route choice API, link loading, path file generation #515

Closed Jake-Moss closed 4 months ago

Jake-Moss commented 7 months ago

TODO:

pedrocamargo commented 7 months ago

@janzill , can you take a look at this PR sometime before next Tuesday? That would allow Jake to jump straight into it

pedrocamargo commented 6 months ago

@Jake-Moss , the API looks pretty good. I think that with some minor tweaks and the example notebook, it will be perfect.

Jake-Moss commented 6 months ago

Didn't realise dict | dict was a 3.9 feature, I'll fix that next week

pedrocamargo commented 6 months ago

Didn't realise dict | dict was a 3.9 feature, I'll fix that next week

We no longer support Python 3.8, though

pedrocamargo commented 5 months ago

@Jake-Moss , in order to save choice sets to disk, we would need to either save the relationship between compact graph link and link/direction or convert it to link_id/direction.

Compact graphs are not permanent, so this becomes dangerous when saving to disk

image

Jake-Moss commented 5 months ago

@Jake-Moss , in order to save choice sets to disk, we would need to either save the relationship between compact graph link and link/direction or convert it to link_id/direction.

Compact graphs are not permanent, so this becomes dangerous when saving to disk

image

What file is that from? I can't see it on the latest commit, I thought that doc string was modified, either way any doc string that mentions the compact links is out of date, except apply_link_loading, which is used by get_load_results to return both https://github.com/AequilibraE/aequilibrae/blob/f55eac93e6c051330f66e56bfdf1af0334d019bf/aequilibrae/paths/route_choice.py#L330-L361 and the translation for the results table happens during its construction https://github.com/AequilibraE/aequilibrae/blob/f55eac93e6c051330f66e56bfdf1af0334d019bf/aequilibrae/paths/route_choice_set.pyx#L1173-L1182

Jake-Moss commented 5 months ago

I believe this is largely ready now, it is lacking select link analysis support, though that will come in a separate PR

Jake-Moss commented 5 months ago

Hmm I thought the CI was fixed...

pedrocamargo commented 5 months ago

Latest Mac-os is now M1...

Jake-Moss commented 5 months ago

Latest Mac-os is now M1...

Hmm that'll do it

Jake-Moss commented 5 months ago

Latest Mac-os is now M1...

I'm not sure what's going on now, the logs files said that the system was build a x86_64 wheel running on arm but deallocate doesn't seem have had an update in the last couple months. I wouldn't have expected that to break it. We'll see how this CI runs, testing locally gave me nothing to go on.

It doesn't seem to be respecting the `--ignore-missing-dependencies``

Jake-Moss commented 4 months ago

This PR is long enough, going to merge into the feature branch and merge develop, hopefully that'll fix some of the CI