search

AequilibraE / aequilibrae

aequilibrae - Python package for transportation modeling
https://www.aequilibrae.com
Other
166 stars 38 forks source link

PT preloading implementation #525

Closed mitsudz closed 2 months ago

mitsudz commented 4 months ago

Development of public transport preload integration into TrafficAssignment

closes #343

pedrocamargo commented 2 months ago

There is a fundamental problem with how the pre-loading is done, which I mentioned in a comment.
Aside from that, I would treat preloads as a single class, with all preloads already there (PT is not the only possible one, as there are multiple urban services that could be considered - e.g. garbage collection, sweeping, etc.). We would not assign them, obviously, but we would include them in the line search and all other portions of the assignment, including results.

pedrocamargo commented 2 months ago

@mitsudz , missing some linting as well.

pedrocamargo commented 2 months ago

@Art-Ev , your pre-loading is ready to merge!!!

Art-Ev commented 2 months ago

Hi ! Could the preloading function be used the same way as capacity or free_flow_time definition functions ? One “set_preload_field” function which, if not set/empty, does not apply preloading for example ? ( would be easier to use than create by yourself a dedicated dataframe, which is ok... but not as smooth ), @pedrocamargo or @mitsudz ?

pedrocamargo commented 2 months ago

The idea is that the user would be allowed to use whatever preloading they would like. Ther is a method for Transit that computes the preloading in the correct format for whatever time-period the user chooses, which they can then inject into the assignment. Does that make sense?