AequilibraE / aequilibrae

aequilibrae - Python package for transportation modeling
https://www.aequilibrae.com
Other
158 stars 38 forks source link

Rename fare_zone_id column #546

Open r-akemii opened 3 weeks ago

r-akemii commented 3 weeks ago

In this PR we rename the variables _fare_zoneid and _farezones in stops and fare_zones transit tables, explaining its relation to stops.txt file in GTFS. We also remove an unnecessary column.

Modifications include:

r-akemii commented 2 weeks ago

Hey @pedrocamargo, I want to check one thing with you before opening this PR. A couple of days ago I asked you if I couldn't remove the _farezone table. You told me it was necessary because it associates the fare zones from stops with the TAZs, but we also have this same information in the stops table, i.e. we have the same information in two different tables. My question is: can we make it simple and keep this info in only one table?

pedrocamargo commented 2 weeks ago

This is wrong.

The fare zone should be transit_fare_zone (and appear in the fare AND stop table), while zone_id should appear only in the stop table and contain the ZONE_ID for the zoning layer