search

AequilibraE / qaequilibrae

Free QGIS add-on for transportation modeling
https://www.aequilibrae.com/qgis/latest/
Other
75 stars 24 forks source link

add processing provider v1 #175

Closed Art-Ev closed 1 year ago

Art-Ev commented 3 years ago

First version of processing provider (usable through processing toolbox and QGIS modeler) Tested on QGIS 3.16 & 3.18 : image image

Art-Ev commented 3 years ago

Looks good to me, not sure what you want to do about mixing english/french in the comments and intermediate variable names. But overall legit - I think that the QGIS processing engine makes things more verbose than they need to be get-vertices, remove duplicates and filter for non-centroids would be 1-2 lines in pure geopandas for instance... but not much you can do about that if you want to use pure QGIS

I'll be more careful not to mix French and English and I'll make a new pull request in full English. For the use of QGIS processes it's also easier for me for the moment but I'll try with geopandas (maybe some computing time to earn at the same time?)

jamiecook commented 3 years ago

Sorry @Art-Ev - I didn't mean those comments directly for your immediate action, it's @pedrocamargo call on the EN/FR thing, and the geopandas comment was more of an observation on the differences between geopandas and QGIS. I don't think it's possible to use geopandas in QGIS directly so your PR is the right way to do this. If you wanted to modify this PR to use english it would make it consistent with the rest of the codebase - but I'm sure that Pedro has left some Portugese in there somewhere :)

Art-Ev commented 3 years ago

Upload to AWS failed, is it possible to relaunch checks @pedrocamargo ?