AequilibraE / qaequilibrae

Free QGIS add-on for transportation modeling
https://www.aequilibrae.com/qgis/latest/
Other
75 stars 24 forks source link

class NetworkPreparationProcedure #302

Closed asxzswqaz closed 6 months ago

asxzswqaz commented 6 months ago

Excuse me for my bad coding. But I believe in the NetworkPreparationProcedure class, the duplication_layer method should be in the class.

Cheers

pedrocamargo commented 6 months ago

Can you substantiate what you are saying?

I will also ask you to only post on one of our communication channels at a time ( I have not accepted the question in the mailing list as it is not relevant due to its lack of context and/or substantiation)

asxzswqaz commented 6 months ago

Hey Pedro,

Sorry for the bad post - I was in a rush yesterday, and didn't get a chance to post the question correctly.

First of all, massive thanks for putting together AequilibraE and making it open source – it's a fantastic tool for all of us in the community.

I've been messing around with AequilibraE in QGIS, specifically trying out the network manipulation tool. Ran into a bit of a hiccup, though. When I was setting up my network using the network preparation tool, the progress bar wouldn't move from 0%, and this error popped up in the log about a missing duplication_layer method in the NetworkPreparationProcedure class.

So, I got curious and poked around in the source code. Looks like there might be a tiny indentation error that's causing the duplication_layer method to sit outside the NetworkPreparationProcedure class instead of inside it (image attached). image

I'm still pretty new to coding, so if I'm off base here, just let me know. But when I tweaked the indentation on my local drive, the error disappeared. Thought I'd pass this on to you in case it's a helpful fix for the project.

Thanks again for all the awesome work on AequilibraE!

Cheers,

pedrocamargo commented 6 months ago

Now this makes sense!

pedrocamargo commented 6 months ago

@r-akemii , let's put this on our long queue of things to do!