AeroPython / PyFME

Python Flight Mechanics Engine
http://pyfme.readthedocs.org/
MIT License
196 stars 70 forks source link

Notebooks updated #101

Closed aeroaks closed 6 years ago

aeroaks commented 7 years ago

output updated and index links corrected

codecov-io commented 7 years ago

Current coverage is 87.25% (diff: 100%)

Merging #101 into master will not change coverage

@@             master       #101   diff @@
==========================================
  Files            28         28          
  Lines          1914       1914          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1670       1670          
  Misses          244        244          
  Partials          0          0          

Powered by Codecov. Last update f2a8c2f...de5f2ae

AlexS12 commented 7 years ago

Hi @aeroaks sorry for my late response here. The plotly plots are amazing and I think it is a good idea to use it as our graphical output.

The notebooks are nice! Just a couple of comments before merging everything:

aeroaks commented 7 years ago

@AlexS12 I will have look at the cause of the text "This is the format of your plot grid:" and how we can avoid it.

I will update the plots to remove the legends both for subplots and the 3D plot. I feel that with the simple plots and other information given, legends can be hidden.

I can provide the hidden legend version very soon. The text seems to be a more involved exploration.

AlexS12 commented 6 years ago

After merging #104 this has no sense anymore. We will keep improving our examples!