AeroRust / nmea

NMEA 0183 - for communication between marine electronics such as echo sounder, sonars, anemometer, gyrocompass, autopilot, GNSS receivers and many other types of instruments. Defined and controlled by the National Marine Electronics Association (NMEA)
https://crates.io/crates/nmea
Other
59 stars 41 forks source link

Supporting additional sentences #54

Open elpiel opened 2 years ago

elpiel commented 2 years ago

There are multiple sentences that are still not implemented in the crate and this is a list of the remaining sentences that we can implement.

Some work has gone into supporting additional sentences - #51

Contributing

  1. Write a comment - Please write a comment for the sentence(s) you'd like to implement and to be mentioned on the task to avoid duplicate implementations.
  2. Implement each sentence alongside at least 1 test in its own module using the nom crate.
  3. Open a PR 🎉

Tips for contributing

Sources

Sentences

In this curated list you'll find sentence types that have yet to be implemented and tested. The standard sentences have priority over the rest of the types and less-known sentences.

bahelms commented 1 year ago

Hello! I'd like to give AAM - Waypoint Arrival Alarm a shot.

elpiel commented 1 year ago

Hello! I'd like to give AAM - Waypoint Arrival Alarm a shot.

I'm adding you to the list AAM sentence then. Thank you for working on this!

clemarescx commented 1 year ago

I wrote 2 tests for BOD - Bearing - Waypoint to Waypoint (tests needed) and presumably fixed an error in BOD parsing, can I send the PR for review?

elpiel commented 1 year ago

I wrote 2 tests for BOD - Bearing - Waypoint to Waypoint (tests needed) and presumably fixed an error in BOD parsing, can I send the PR for review?

Of course, you can. I will update the task and assign it to you.

ekuinox commented 1 year ago

Hello! I wanna try to implement parser for HDT sentence.

elpiel commented 1 year ago

Hello! I wanna try to implement parser for HDT sentence.

Great to hear this @ekuinox , I'm adding you on this sentence them 😋

ekuinox commented 1 year ago

I'd like to work on ZDA and VHW. 😄

elpiel commented 1 year ago

I'd like to work on ZDA and VHW. smile

They are both yours 😋 have fun implementing them

taavit commented 1 year ago

I'd like to pick BWW, ZFO and ZTG.

elpiel commented 1 year ago

I'd like to pick BWW, ZFO and ZTG.

Thank you for your interest to contribute to the nmea crate! I have assigned those messages to you.

rafiramadhana commented 1 year ago

I'd like to pick DBS - Depth Below Surface.

elpiel commented 1 year ago

Thanks for your interest to contribute @rafiramadhana! I'm assigning you to the sentence parsing :yum:

Tsuiban commented 1 year ago

I'd like to take a swing at VWT (True wind speed and angle).

elpiel commented 1 year ago

Great to hear that @Tsuiban! I've assigned you to the sentence

elpiel commented 10 months ago

@Tsuiban are you still interested in working on VWT sentence?

mgrouch commented 10 months ago

There is this list of sentences as json. I think it could be just used to generate code of all parsers

https://github.com/SmartBoatInnovations/ha-smart0183/blob/main/custom_components/smart0183/Smart0183.json

elpiel commented 10 months ago

Thank you for sharing this resource @mgrouch! Although we could generate the sentences from the JSON, it will rather be used as another source of information for sentences.

Writing these parsers and generating them from the JSON might take more time than what's worth.

What we still need to support is Rust Struct to NMEA sentence and the iterator based parser, as top priority right now

zhrbrk commented 7 months ago

Hello, I'd like to work on GST.

elpiel commented 7 months ago

Hello, I'd like to work on GST.

Great to hear that @zhrbrk ! I'm assigning you to the sentence in the list.

Tapped commented 4 months ago

Hi, I added support for TTM here: https://github.com/AeroRust/nmea/pull/128

trkohler commented 1 month ago

started to work on DPT - Depth of Water