Closed Turbo87 closed 2 years ago
Great progress for the support of RMZ messages.
There are a few points that need addressing:
fn parse_str()
RMZ
) but also the talker_id, it should be PG
. I think we can create an UnknownTalkerId
error and pass a custom expected
value (&'a [&'a str]
) for PG
talker_id != PG
should give out an error)Base: 76.80% // Head: 76.76% // Decreases project coverage by -0.03%
:warning:
Coverage data is based on head (
f65c8cc
) compared to base (03695a6
). Patch coverage: 75.00% of modified lines in pull request are covered.:exclamation: Current head f65c8cc differs from pull request most recent head 7b0ef1f. Consider uploading reports for the commit 7b0ef1f to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
- Add new sentence type to the
fn parse()
tbh I'm not convinced that we should be merging this data with the rest in the parse()
function. the PGRMZ
sentence usually contains a barometric or pressure altitude, while the regular NMEA sentences contain GPS altitudes, which can often have significant offsets due to the current weather situation. if we would merge them and pretend like they contain the same information then the altitude will regularly jump all over the place.
@Turbo87 I was referring to the parse_str
(I made a typo) which is able to parse all types of sentences, not like the NMEA::parse()
:
https://github.com/AeroRust/nmea/blob/03695a6d0dacdf39f16ba83338d040418ef6fd54/src/parse.rs#L134
Ah, I see. That makes sense :)
I'll update the PR in the next couple of days once EuroRust is over
Awesome, thank you 🥳
Thank you 🥳
$PGRMZ
is used by a lot of gliding computers like the https://gliding.lxnav.com/products/lx9000/ to transmit the current barometric altitude.This PR implements basic support for it. It is currently implemented to output the raw altitude in feet without any conversions.