Closed bahelms closed 1 year ago
@elpiel I have a question about the AAM sentence. I see that Nmea::parse
does not support all sentences. It would seem AAM should also not be supported here based on the docs:
/// Parse any NMEA sentence and stores the result of sentences that include:
/// - altitude
/// - latitude and longitude
/// - speed_over_ground
/// - and other
///
/// The type of sentence is returned if implemented and valid.
pub fn parse(&mut self, sentence: &'a str) -> Result<SentenceType, Error<'a>> {
Is this correct?
Yes, that is correct.
Thank you for the PR 🎉
@bahelms should I take a look at the PR or do you need to finish something else first? There is also a conflict right now, would ou mind resolving it?
@bahelms should I take a look at the PR or do you need to finish something else first? There is also a conflict right now, would ou mind resolving it?
@elpiel Yes, it's ready for review now. Thanks!
Base: 78.54% // Head: 79.22% // Increases project coverage by +0.67%
:tada:
Coverage data is based on head (
08ccbbb
) compared to base (d5f1209
). Patch coverage: 96.15% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
LGTM. A BIG Thanks 🎉 for contributing to the project!
PS: Let's see if CI runs successfully and we can merge it.
Thank you! My pleasure.
Add AAM sentence parser