elpiel
commented
1 year ago Thank once again for this PR! I will leave 1 task in the main issue for adding an assertion for the 10bit week number as it's not covered by tests. You're welcome to open a new PR for it if you want to add it.
Codecov Report
Base: 79.84% // Head: 80.22% // Increases project coverage by
+0.37%:tada:Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #71 +/- ## ========================================== + Coverage 79.84% 80.22% +0.37% ========================================== Files 24 25 +1 Lines 933 976 +43 ========================================== + Hits 745 783 +38 - Misses 188 193 +5 ``` | [Impacted Files](https://codecov.io/gh/AeroRust/nmea/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust) | Coverage Δ | | |---|---|---| | [src/parser.rs](https://codecov.io/gh/AeroRust/nmea/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust#diff-c3JjL3BhcnNlci5ycw==) | `78.43% <0.00%> (-0.31%)` | :arrow_down: | | [src/sentences/mod.rs](https://codecov.io/gh/AeroRust/nmea/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust#diff-c3JjL3NlbnRlbmNlcy9tb2QucnM=) | `0.00% <ø> (ø)` | | | [src/sentences/alm.rs](https://codecov.io/gh/AeroRust/nmea/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust#diff-c3JjL3NlbnRlbmNlcy9hbG0ucnM=) | `89.74% <89.74%> (ø)` | | | [src/parse.rs](https://codecov.io/gh/AeroRust/nmea/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust#diff-c3JjL3BhcnNlLnJz) | `81.81% <100.00%> (+0.33%)` | :arrow_up: | | [src/sentences/utils.rs](https://codecov.io/gh/AeroRust/nmea/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust#diff-c3JjL3NlbnRlbmNlcy91dGlscy5ycw==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.