AeroRust / nmea

NMEA 0183 - for communication between marine electronics such as echo sounder, sonars, anemometer, gyrocompass, autopilot, GNSS receivers and many other types of instruments. Defined and controlled by the National Marine Electronics Association (NMEA)
https://crates.io/crates/nmea
Other
56 stars 41 forks source link

Add ZDA sentence parser #83

Closed ekuinox closed 1 year ago

ekuinox commented 1 year ago

54 Implements parser for ZDA sentence.

Does NMEA::parse_for_fix need to support ZDA ? I've not implemented it yet. 🤔

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 95.83% and project coverage change: +0.99 :tada:

Comparison is base (725394f) 79.24% compared to head (2ea3139) 80.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #83 +/- ## ========================================== + Coverage 79.24% 80.24% +0.99% ========================================== Files 27 28 +1 Lines 1012 1058 +46 ========================================== + Hits 802 849 +47 + Misses 210 209 -1 ``` | [Impacted Files](https://codecov.io/gh/AeroRust/nmea/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust) | Coverage Δ | | |---|---|---| | [src/lib.rs](https://codecov.io/gh/AeroRust/nmea/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust#diff-c3JjL2xpYi5ycw==) | `0.00% <ø> (ø)` | | | [src/parser.rs](https://codecov.io/gh/AeroRust/nmea/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust#diff-c3JjL3BhcnNlci5ycw==) | `77.90% <0.00%> (+0.08%)` | :arrow_up: | | [src/sentences/mod.rs](https://codecov.io/gh/AeroRust/nmea/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust#diff-c3JjL3NlbnRlbmNlcy9tb2QucnM=) | `0.00% <ø> (ø)` | | | [src/parse.rs](https://codecov.io/gh/AeroRust/nmea/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust#diff-c3JjL3BhcnNlLnJz) | `72.15% <100.00%> (+0.72%)` | :arrow_up: | | [src/sentences/zda.rs](https://codecov.io/gh/AeroRust/nmea/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust#diff-c3JjL3NlbnRlbmNlcy96ZGEucnM=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

elpiel commented 1 year ago

Does NMEA::parse_for_fix need to support ZDA ? I've not implemented it yet. thinking

Yes, it would be nice (in a follow up PR)

Thank you for the PR :rocket: