AeroRust / nmea

NMEA 0183 - for communication between marine electronics such as echo sounder, sonars, anemometer, gyrocompass, autopilot, GNSS receivers and many other types of instruments. Defined and controlled by the National Marine Electronics Association (NMEA)
https://crates.io/crates/nmea
Other
56 stars 41 forks source link

Tests for sentences/utils.rs #88

Open gflow33 opened 1 year ago

gflow33 commented 1 year ago

Additional tests for sentences/utils.rs, tests are meant to fail but are written in different ways. Please review and tell me the best way to proceed

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (b203556) 79.60% compared to head (44ce869) 79.60%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #88 +/- ## ======================================= Coverage 79.60% 79.60% ======================================= Files 30 30 Lines 1123 1123 ======================================= Hits 894 894 Misses 229 229 ``` | [Impacted Files](https://codecov.io/gh/AeroRust/nmea/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust) | Coverage Δ | | |---|---|---| | [src/sentences/utils.rs](https://codecov.io/gh/AeroRust/nmea/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust#diff-c3JjL3NlbnRlbmNlcy91dGlscy5ycw==) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AeroRust)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

elpiel commented 10 months ago

@gflow33 Do you have any progress on these tests?

elpiel commented 6 months ago

@gflow33 have you made any progress on this PR?

trkohler commented 1 week ago

connect: https://github.com/AeroRust/nmea/issues/25