Closed ekuinox closed 1 year ago
Hmmm... I would instead leave them in their respective module making them public and keep the same names. If someone wants to rename the import they can do it. Long names are never something I personally prefer.
We can do breaking changes, it's not a big deal, especially bumping minor versions.
And Thank you for the PR!
Changed to make all modules under nmea::sentences
public.
Also, some SentenceType
parsing was missing, so it has been added.
Patch coverage: 33.33
% and project coverage change: -0.04
:warning:
Comparison is base (
2d30392
) 80.35% compared to head (f465474
) 80.31%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Changes
I Added below enums exporting.
RmcNavigationStatus
GsaMode1
GsaMode2
PgrmzFixType
I think it would be better to rename
NavigationStatus
toGnsNavigationStatus
to clarify the difference fromRmcNavigationStatus
. However, this would be a destructive change, so I would like your opinion. I think it would be better to export the names of bothNavigationStatus
andGnsNavigationStatus
, but encourageNavigationStatus
to use#[deprecated]
to useGnsNavigationStatus
.