Aeroluna / NoodleExtensions

This mod lets you see cool things that mappers have put in their maps. Report all issues to Reaxt.
MIT License
158 stars 40 forks source link

[BUG] Double Notes with Multiplayer Extension #29

Closed WiredG1 closed 3 years ago

WiredG1 commented 3 years ago

PC

I posted this in multiplayer extension as per instruction from boulders2000; a mod on the beat saber modding group discord. Zingabopp then said: "This is purely a NoodleExtensions issue." So I am posting it here.

When playing a song with noodle extensions and multiplayer extensions a second note will appear and start turning the wrong way. This extra note is unhittable. It seems to not be a problem when one of the two players die. This is making me think that the second players notes are in the wrong "lane". Used song in the video: https://beatsaver.com/beatmap/11cf8 Link to video: https://1drv.ms/u/s!AkaSnPycUYb2h2nrnuuaBo-nOM8Q?e=2aqVoP

Reproduce

  1. Start multiplayer server with 2 players
  2. Select song with noodle extensions
  3. Double notes

https://github.com/Zingabopp/MultiplayerExtensions/files/5791656/_latest.log

SteffoSpieler commented 3 years ago

Had this too, but with 4 Players. Same song. After like 1 Minute I had only 1 to 3 fps.

thelightdesigner commented 3 years ago

Not that it doesn't make sense, ne controls the exact positions of notes. So this isn't exactly a bug but more of a consequence of the way beatgames made other players notes into actual notes.

jewlexx commented 3 years ago

Noodle extensions doesn't support multiplayer... it's right there on the download thing

SteffoSpieler commented 3 years ago

Maybe you don't know that, but that info on the release page was added after this issue was created. The release 1.3.4 has not that info.

Sudospective commented 3 years ago

Is there currently anything in place to match which notes belong to which player? I wonder if we can make a test map that swaps the two players' positions and tries to make them play each other's notes...

Aeroluna commented 3 years ago

Multiplayer support added https://github.com/Aeroluna/NoodleExtensions/commit/49afe0aa1f92fd6f7768bb1989aedbb1c410b612