Aeroluna / NoodleExtensions

This mod lets you see cool things that mappers have put in their maps. Report all issues to Reaxt.
MIT License
158 stars 40 forks source link

Notes spawn too high when player is moved. #43

Closed Lauriethefish closed 3 years ago

Lauriethefish commented 3 years ago

In maps like Lost Memory, and The Wall Remastered, the notes spawn about one lane too high for me. This doesn't happen initially, but only once the map has moved you from your normal position.

Version: Latest from Releases Beat Saber Version: 1.13.2 Installed Plugins: https://imgur.com/a/ESoMstC

This is what the notes in The Wall are supposed to look like: https://youtu.be/8ipOK0g8H3w?t=144 This is what they look like for me: https://www.youtube.com/watch?v=4hEZK6l_3JI

It's not my player height, since notes spawn fine in normal maps.

Mawntee commented 3 years ago

If you have "AutoPlayerHeight" checked, the game will calculate your height mid song as well. So if the chart moves you up, it will think you are a lot taller than you actually are and adjust the game accordingly.

You can get around this by actually setting a consistent player height, and not using "auto".

That said, a fix for this would be nice! Not sure if possible though

Lauriethefish commented 3 years ago

Ahh, that makes perfect sense actually. Thanks for explaining it to me. I guess the fix would be to modify the game to calculate the player height relative to the map's player position.

Aeroluna commented 3 years ago

Fixed https://github.com/Aeroluna/NoodleExtensions/commit/35f49b745276bf2bb8527be9295429c9178e37d1

Lauriethefish commented 3 years ago

Thank you :)