search

Aeroluna / NoodleExtensions

This mod lets you see cool things that mappers have put in their maps. Report all issues to Reaxt.
MIT License
158 stars 40 forks source link

Huge memory leak after installing Noodle/Chroma/Technicolor/Heck for 1.16.1 #62

Closed friesofdoom closed 3 years ago

friesofdoom commented 3 years ago

Beat saber using almost all of my 64 gigs of ram...

image

Top-Cat commented 3 years ago

As helpful as a single screenshot is maybe a description of what you did prior to this and/or including the logs from the game would actually mean something could be done to fix the issue.

Meivyn commented 3 years ago

Can you please share your logs? And pretty much what Top-Cat asked, any step to reproduce?

hamcoremusic commented 3 years ago

I was able to play just fine with no memory issues using latest Noodle and Chroma, no Technicolor. I wonder if this is just a random thing or if it's tied to a specific event in a map.

Meivyn commented 3 years ago

I can't confirm this is the same issue to be honest (since I haven't had time to see anything in task manager), but I had a PC crashing issue yesterday. It started with USB disconnect/reconnect sounds, then a lot of stuttering in game, then all of my USB ports (including RGB lights) died (that's when I noticed since the screen of my headphones was off), then the PC literally froze. This is most likely the same issue, as I haven't played any NE/Chroma maps until... yesterday. I didn't have my two controllers to do it. But you'd really have to compare the mod list to make sure it's due to Aero's mods.

Either way, more investigation is needed before anything is officially published on BSMG.

@friesofdoom would like a lot having more information on this.

Meivyn commented 3 years ago

I can pretty much confirm there is a leak now, but I can't confirm it's because of Aero's mods.

image image

Within 5 seconds or so. It seems to be exponential.

image

Time to stop.

Meivyn commented 3 years ago

Found a way to reproduce. Time to find the culprit.

Meivyn commented 3 years ago

The culprit is either Chroma, Noodle, or Heck. No one should install this before it's fixed, since it's a potential leak of 1 Gb by second.

image

Fatalution commented 3 years ago

The culprit is either Chroma, Noodle, or Heck. No one should install this before it's fixed, since it's a potential leak of 1 Gb by second.

image

In further testing with @Meivyn , that's what we found:

Map tested: https://beatsaver.com/beatmap/16992 We have produced 2 additional diffs for the map - one that contained everything aside of Noodle _customEvents (so the Noodle walls were still there), another one - containing only Chroma events with no notes or Noodle events/walls.

  1. The RAM issue occurred only on @Meivyn side. It is NOT reproducible on my side
  2. The issue also occurred with Chroma removed, as well as only Chroma version of the map
  3. The issue ALSO occurred on the vanilla install on the 100$ Bills. Yup. That happened
  4. The issue DID NOT occur when using SteamVR mode
  5. The issue is VERY apparent when the headset is removed

We now suspect Oculus runtime. @friesofdoom it would be very helpful if you provide us with much more info on this one. This is potentially a vanilla game's bug which we have stumbled upon

friesofdoom commented 3 years ago

It happened once, and then I uninstalled chroma/noodle/technicolor/heck because i wanted to murder cubes (plus I'm getting instant fails on most noodle maps as per my other issue - https://github.com/Aeroluna/NoodleExtensions/issues/61).

The memory leak hasn't happened since I've uninstalled everything.

All I did was try a few noodle maps, and then noticed the game running a bit slow and using loads of memory. I'm not sure what I can do to help but let me know if you have something specific you wanted me to try...

Fatalution commented 3 years ago

It happened once, and then I uninstalled chroma/noodle/technicolor/heck because i wanted to murder cubes (plus I'm getting instant fails on most noodle maps as per my other issue - #61).

The memory leak hasn't happened since I've uninstalled everything.

All I did was try a few noodle maps, and then noticed the game running a bit slow and using loads of memory. I'm not sure what I can do to help but let me know if you have something specific you wanted me to try...

The fail on note cut was fixed in the latest release. Make sure you are on the latest Chroma, Heck and NE versions because they have been updated quite recently.

Regarding something specific:

  1. Try installing Chroma, NE and Heck again and see if you encounter the same issue. Make sure to use the latest versions
  2. Try running through SteamVR with same mods and see if you encounter the same issue. If the issue is still present, go to step 3
  3. Reboot. See if the issue is still present under SteamVR. If not - check -vrmode oculus.

If you encounter the issue at step 3, please post the _latest.log from your Logs folder, as well as complete list of your mods (or screenshot your Plugins folder, both would work)

It would be advisable to check your Task Manager after playing every Noodle/Chroma map. See if you spot an exponential RAM usage climb. If you do - please provide the map's ID so we can test those as well.

Thanks in advance!

friesofdoom commented 3 years ago

I'm using an Index, so no oculus, everything is through steamvr. Let me check the releases I'm using....I thought I was on the latest release of them all, ill update and see what happens.

Fatalution commented 3 years ago

I'm using an Index, so no oculus, everything is through steamvr. Let me check the releases I'm using....I thought I was on the latest release of them all, ill update and see what happens.

So, the note cut was resolved - actually outdated Chroma, so that's out of the window. Now, in regards to you using the Index - NICE. Meaning it's actually Beat Saber.

ACTUALLY it can be the case you've just had outdated Chroma = the RAM bug as well. Try and test it now and see if you can spot it.

And well, if you do spot it even with updated mods (and make sure that others are updated as well) - then go ahead and paste the usual:

  1. Log
  2. Mod list
friesofdoom commented 3 years ago

I'll let you know if I get it again! Thanks!

Fatalution commented 3 years ago

I'll let you know if I get it again! Thanks!

It seems you haven't gotten it yet and that the new Chroma version actually fixed that issue for you. How long has it taken before to kick in?

Meivyn commented 3 years ago

That's a base game issue and got reported to devs:

Exact steps to reproduce

Strangely enough, you seem to use an Index, and I really doubt an old Chroma or Noodle would have caused this leak in the first place. There is maybe a way to reproduce it on SteamVR... having two reports of memory leak on the same patch is probably not a coincidence.

@friesofdoom Either way, we would really like it if you can zip your whole Logs folder and posting it here, with an approximation of the date the issue happened since that screen doesn't include the date.

Fatalution commented 3 years ago

Strangely enough, you seem to use an Index, and I really doubt an old Chroma or Noodle would have caused this leak in the first place. There is maybe a way to reproduce it on SteamVR... having two reports of memory leak on the same patch is probably not a coincidence.

Nah, that's actually expectable for the RAM issue to occur there. It happens because Colorizer was throwing exceptions all around and they were piling up on every map/note. Hence, RAM usage spiked.

Therefore, the new version is not affected by this bug since Colorizer was fixed

Meivyn commented 3 years ago

We found out this was also happening with SteamVR, and started with game version 1.14.0 which introduced the GC "fix". According to an official mapper, devs "dumped all the garbage into Dash and SteamVR". That issue doesn't need more investigation.

@Aeroluna This can be closed.