AesopInteractive / lasso

Code Repository for Editus (formerly Lasso) Commercial Plugin
https://edituswp.com
GNU General Public License v2.0
147 stars 25 forks source link

Support Adding Stock WordPress Image #12

Closed bearded-avenger closed 9 years ago

bearded-avenger commented 9 years ago

if the image is already existing and added from the backend post editor, and you load lasso and go to edit it, you can edit the image. need to support adding the image from with lasso, by always having the + icon there.

no aesop == support for adding at least image aesop == thats removed, aesop components loaded

michaelbeil commented 9 years ago

Well now, there we go.

bearded-avenger commented 9 years ago

done in 0.9.1

michaelbeil commented 9 years ago

Seems to be an issue when inserting an image as noted by rob.

"It looks like this is your culprit:

https://gist.github.com/robneu/546f33c386d34c0a576b#file-process-wpimg-js-L6

That’s in public/assets/js/src/process-wpimg.js

If you set up a fallback, I think you should be alright. Whenever an image isn’t large enough for a “large” version to be generated, everything wigs out. It also starts trying to fire the sidebar when you’ve set an image but it can’t find a var with the image properties so an empty sidebar pops out instead of the image edit modal. Some error handling in the function that fires the modal might also be good."

michaelbeil commented 9 years ago

screen capture on 2015-03-27 at 22-11-01

michaelbeil commented 9 years ago

screen shot 2015-03-27 at 21 48 48

bearded-avenger commented 9 years ago

this was fixed