AesopInteractive / lasso

Code Repository for Editus (formerly Lasso) Commercial Plugin
https://edituswp.com
GNU General Public License v2.0
147 stars 25 forks source link

Real-time bug in Video component #75

Closed michaelbeil closed 9 years ago

michaelbeil commented 9 years ago

When changing to a different video source, the video component does not show changes in real-time.

screen shot on 2015-05-27 at 15_54_38

The default is Vimeo, so changing to a different Vimeo video ID (or from any other video source) is fine: https://github.com/AesopInteractive/lasso/blob/master/public/includes/components.php#L214.

image 2015-05-27 at 2 53 36 pm

So, to see a change in the video source, it requires a save, and then a page refresh.

screen shot on 2015-05-27 at 15_51_33

We currently set Vimeo:

if ( iSrc.hasClass('vimeo') ) {
    component.find('iframe').attr('src', '//player.vimeo.com/video/'+src+' ')
} else if ( iSrc.hasClass('youtube') ) {
    component.find('iframe').attr('src', '//www.youtube.com/embed/'+src+'?rel=0&wmode=transparent')
}

https://github.com/AesopInteractive/lasso/blob/master/public/assets/js/source/settings-live-editing.js#L230-L234

michaelbeil commented 9 years ago

:100: