search

AesopInteractive / lasso

Code Repository for Editus (formerly Lasso) Commercial Plugin
https://edituswp.com
GNU General Public License v2.0
147 stars 25 forks source link

Allow sub-site settings on multisite #76

Open bearded-avenger opened 9 years ago

bearded-avenger commented 9 years ago

add a filter to override mu saving to get_site_option to allow settings to be configured on a per site bases

michaelbeil commented 9 years ago

Noticed this the other day and was gonna make a note. You beat me to it.

robmcclel commented 9 years ago

Hey, guys, how's this one coming along?

bearded-avenger commented 9 years ago

Hey Rob, This is in fact pretty deep in it's nature, which is why it hasn't happened yet.

robmcclel commented 9 years ago

Thanks, Nick. Please keep me posted. I just downloaded the latest release and am testing now.

On Thu, Jun 18, 2015 at 10:27 AM, Nick Haskins notifications@github.com wrote:

Hey Rob, This is in fact pretty deep in it's nature, which is why it hasn't happened yet.

— Reply to this email directly or view it on GitHub https://github.com/AesopInteractive/lasso/issues/76#issuecomment-113227660 .

robmcclel commented 9 years ago

Good news -- the latest release found the structure underneath the our Genji Child Theme and worked as expected for the site admin. However, it would not work for any other member level, I imagine because there is a setting somewhere in the menu I can't access that needs to be set or adjusted.

When a non-admin tries to create a post, it goes through the motions but results in a page like this:

lasso bummer

Is there a way I can get around this in the short term?

bearded-avenger commented 9 years ago

There are no settings to enable to other users. What user level are you testing? If a use cannot publish_posts then it wont publish a post.

robmcclel commented 9 years ago

As the Site admin, I have no problems creating or publishing a post. Just did it, in fact.

As a "Contributor" or "Author", Lasso appeared and I was able to start the post creation process -- but it ended in that "Bummer" page. I can understand the Contributor level failing, but I figured "Author" would work fine.

On Thu, Jun 18, 2015 at 11:17 AM, Nick Haskins notifications@github.com wrote:

There are no settings to enable to other users. What user level are you testing? If a use cannot publish_posts then it wont publish a post.

— Reply to this email directly or view it on GitHub https://github.com/AesopInteractive/lasso/issues/76#issuecomment-113245390 .

bearded-avenger commented 9 years ago

yep there's a bug with author. but this nothing to do with MU settings. thanks for letting us know.

robmcclel commented 9 years ago

Great, thanks!

Again, keep me posted. I don't want the users to be able to cross-edit other people's posts, so let me know when this bug is fixed and the plugin can be used in public.

Feel like it's really getting close. Pretty excited...

On Thu, Jun 18, 2015 at 11:27 AM, Nick Haskins notifications@github.com wrote:

yep there's a bug with author. but this nothing to do with MU settings. thanks for letting us know.

— Reply to this email directly or view it on GitHub https://github.com/AesopInteractive/lasso/issues/76#issuecomment-113250540 .

bearded-avenger commented 9 years ago

heh, users cannot cross-edit other peoples posts, only users with the correct permissions can do that.

The only bug here is that an author cant publish a post.

Will update this soon.

robmcclel commented 9 years ago

Right -- but as it stands, the only way someone other than the admin could post is to be an Editor, which means they would have access to other posts. For my purposes, users can't be higher than "Author" -- so I'll wait for the update.

On Thu, Jun 18, 2015 at 11:35 AM, Nick Haskins notifications@github.com wrote:

heh, users cannot cross-edit other peoples posts, only users with the correct permissions can do that.

The only bug here is that an author cant publish a post.

Will update this soon.

— Reply to this email directly or view it on GitHub https://github.com/AesopInteractive/lasso/issues/76#issuecomment-113252413 .

michaelbeil commented 9 years ago

@robmcclel to keep up with the author issue see #91.

Also, Lasso respects WordPress' user roles and capabilities as outlined in the codex here: https://codex.wordpress.org/Roles_and_Capabilities. So, no need to worry about cross-editing occurring, unless that user is an admin or editor, or they can edit_others_pages or edit_others_posts, etc.

We will be working to get a fix out for this soon. Thanks for the heads up!

robmcclel commented 9 years ago

Thank you, Mike and Nick! Extremely positive on Lasso here at TS and the users are definitely looking forward to it.

On Thu, Jun 18, 2015 at 11:42 AM, Michael Beil notifications@github.com wrote:

@robmcclel https://github.com/robmcclel to keep up with the author issue see #91 https://github.com/AesopInteractive/lasso/issues/91.

Also, Lasso respects WordPress' user roles and capabilities as outlined in the codex here: https://codex.wordpress.org/Roles_and_Capabilities. So, no need to worry about cross-editing occurring, unless that user is an admin or editor, or they can edit_others_pages or edit_others_posts, etc.

We will be working to get a fix out for this soon. Thanks for the heads up!

— Reply to this email directly or view it on GitHub https://github.com/AesopInteractive/lasso/issues/76#issuecomment-113253813 .

bearded-avenger commented 9 years ago

Awesome Rob!!

lkraav commented 9 years ago

Is this issue the one to follow on why lasso doesn't create the correct settings page url when activated on a subsite? From what I can see from 0.9.6 usage of is_multisite() the code is prepared only to be network-activated. Not something I'm looking to do.

Documentation confuses me https://lasso.is/help/using-lasso/ because it claims Lasso is subsite-ready.

bearded-avenger commented 9 years ago

The documentation says the following (the word "subsite" appears nowhere on that page)

Lasso can be network activated, if you want all of the sites on the network to use the same settings. When Lasso is network activated, a settings panel will appear under the Network Settings tab

Which is correct, and is how it operates. Per site settings is what this issue report is, and it's on the long list to be implemented. PR's are absolutely welcome if you want to take this on yourself.

lkraav commented 9 years ago

My bad, I remembered the wrong link. https://lasso.is/faq/ is the misleading one.

bearded-avenger commented 9 years ago

Thanks, I just edited the page. In the beginning per site settings is how it was, but then we needed it to work on a global level for https://story.am (it's what the editor was originally developed for). The best thing to do for now until we get single site support, is make sure the article css class is the same.

If you have 50 themes and you have 50 sites, then make sure all 50 themes have the same article CSS class so that the editor works on subsites with different themes.

robmcclel commented 9 years ago

As a temporary workaround for those wanting to activate on a single site (only) in a MU install, here is something that worked for me.

If you network activate Lasso, it gives you access to the settings. Fill them out for the one site you want to enable Lasso, then save. Once saved and you verify it works on your single site, network deactivate the plugin. Head over to the single site and activate the plugin for that site. The settings will hold, and Lasso will be active.

Very excited about really getting this plugin out in the wild on the network -- can't wait for 1.0 so I can offer it as an option on all of our sites.