AesopInteractive / lasso

Code Repository for Editus (formerly Lasso) Commercial Plugin
https://edituswp.com
GNU General Public License v2.0
147 stars 25 forks source link

Multiple galleries #80

Closed michaelbeil closed 9 years ago

michaelbeil commented 9 years ago

When adding more than one gallery, all galleries receive the last added gallery ID.

It seems like our API is dynamically updating all galleries to be equal. However, all galleries are not equal.

// make an ajax call to deal with gallery saving or creating only if it's a gallery
if ( 'gallery' == cdata['componentType'] ) {

    var data = {
        action:         form.hasClass('creating-gallery') ? 'process_gallery_create' : 'process_gallery_update',
        postid:         lasso_editor.postid,
        unique:         cdata['unique'],
        fields:         cleanFields(cdata),
        gallery_type:   $('#ase_gallery_type').val(),
        gallery_ids:    $('#ase_gallery_ids').val(),
        nonce:          $('#lasso-generator-nonce').val()
    }

https://github.com/AesopInteractive/lasso/blob/master/public/assets/js/source/process-save-component.js#L39-L107

zamoose commented 9 years ago

Came here to post about the exact same thing. Add a second gallery, and it seems to nuke everything beyond said gallery.

bearded-avenger commented 9 years ago

seems to check out locally ^

michaelbeil commented 9 years ago

I tested release/0.9.5 and I cannot create a second gallery with Lasso from the front-end without needing to create a new gallery from the WordPress dashboard under ASE's gallery CPT. screen shot 2015-06-08 at 2 55 34 pm

bearded-avenger commented 9 years ago

eh?

bearded-avenger commented 9 years ago

can you make a new issue? that's a bug in teh workflow I've been meaning to fix (it's separate than this postid cross contamination crud)

michaelbeil commented 9 years ago

Done.

zamoose commented 9 years ago

Michael: I think this is the status quo? I had to do the same as well.

Also, using the Cover theme, all the text is the wrong color in the Lasso fly-overs. I'm betting it's a bad CSS rule specific to the theme, but it's still a problem.

On Mon, Jun 8, 2015 at 4:02 PM, Nick Haskins notifications@github.com wrote:

eh?

— Reply to this email directly or view it on GitHub https://github.com/AesopInteractive/lasso/issues/80#issuecomment-110121498 .

-Doug

bearded-avenger commented 9 years ago

makes note to pull down cover

michaelbeil commented 9 years ago

@zamoose ~~> https://github.com/AesopInteractive/lasso/issues/86

re Cover: screen shot 2015-06-08 at 3 08 54 pm

Looks like Cover's styles are overwriting Lasso's sidebar styles: screen shot 2015-06-08 at 3 24 20 pm

bearded-avenger commented 9 years ago

lasso doesnt have any styles set which is why it's overriding. will fix.

michaelbeil commented 9 years ago

Aha.